Start with some basics?
Before you get a new iPad and foreflight, get a new flight instructor!
So far, two pages of replies and various diverse opinions. I'd begin at the biginning - what is your mission profile? (It may be too early in your flying career to 'nail it down') but the OP should have some concept of the type of plane, and aviation objectives desired. If I look back on my decades of aviation exposure the basics haven't changed, but been refined. Never thought of being a commercial, airline, for hire, multi-engine, or acro-guy. Wanted short haul (one to two days) cross-country transportation in VFR conditions. Wanted the latest technology available and not vintage or fading era of nostalgia, enjoy it, but not my mission profile.
Every answer for which version of tablet and app will change regularly and the 'best' answer may be free today and Android, or compatible with another advancing world. If the OP wants to ultimately get Instrument rating and have more advanced training then ForeFlight and iPad versions may be the 'path' that most closely leads there. But if he wants to tool around the vicinity and do back-country then it may be another option. In two years will the choice today matter? Maybe ... it depends. Will the APP still be around? or will it be litter on the technology highway? Maybe
If the intent is to build an RV-10 and fly the family in a Garmin equipped panel, then it may be another consideration. Who will spend $100K to build the dream and then make decisions on a tablet/app based on FREE to save the cost of a tank of gas?
I've been Dynon SkyView and iPad Mini2 (and 4) with ForeFlight (Basic and now Pro) - love the compatibility and features, the support and the continuously advancing releases. Just upgraded to the iPad 9.7" 2017 version. All VFR, local and cross-country. The WiFi link to SkyView is important; AHRS/GPS data, transfers flightplans bi-directionally. (Learned on steam gauges but could not find my bxxx with a VOR today with both hands.) Have/Use a BadElf Pro for backup GPS input to ForeFlight. iPads are ALWAYS for me, WiFi ONLY. There is NO GPS in a WiFi only iPad. Cellular versions include a GPS, but use of cellular while in the air will use the battery faster - is that a factor? (for the OP?). The BadElf is a much better GPS than the basic/built-in GPS in an iPad.
The future is some version of technically advanced aircraft (TAA) and I'd want to get the most/best training today with an instructor who will embrace that path. Would regret getting a PPL in a Warrior II and no technology (tablet) only to have to mentally start over with the technology. NDB's are being deactivated, VOR's will possibly follow or be cut-back. Look ahead and make choices to fill your mission profile objectives.